Added option to use short (two letter) language codes for the subtitle extension#41
Open
Sebazzz wants to merge 6 commits intoexebetche:masterfrom
Open
Added option to use short (two letter) language codes for the subtitle extension#41Sebazzz wants to merge 6 commits intoexebetche:masterfrom
Sebazzz wants to merge 6 commits intoexebetche:masterfrom
Conversation
…e extension, and also refactored and commented the interface code for easier extension
2.2 is officially released
Spanish translation updated
Contributor
|
Hi Sebastian, that's a great functionality. I also would like to put this feature on the code and I tried by my self but I have a little bug yet when I apply the changes, the plugin is selecting a wrong option. So if your code is ok it would be great to use it or if you can help me with mine may be we can finish it. |
Contributor
Author
|
I will try to merge from upstream master, then commit again. Hold on :) |
…e extension, and also refactored and commented the interface code for easier extension
Conflicts: vlsub.lua
Contributor
Author
|
Alright, I have rebased on top of master. |
Contributor
|
Ok thanks I'm going to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option to use the short two-letter language code for the subtitle extension instead. For example, dutch subtitles would have the 'nl' extension instead of 'dut'.
Also, I refactored and commented the interface code, so it is easier to add new interface items.