Multiple options to language code in file name

[adrianparisi]

Hello, im doing a modification because i want to select the language code for the file in iso-639-1 or iso-639-3. For example i need to use the extension .es.srt instead of .spa.srt.

Now I think that is working fine.

[adrianparisi]

I realize that I have not explained how it works, for do some test.

It's really easy, in the configuration there is an option 'Display language code in file name'. That combo had two values 'No' (default) or 'Yes', now I open that and I put three values 'No' (default), 'Yes (2 chars)' and 'Yes (3 chars).

So It's really easy as I said, if have any question can ask me.

[ArielCabib]

hi, please resolve the conflicts and i'll merge it to my fork
https://github.com/ArielCabib/vlsub/pull/4

[adrianparisi]

Hi Ariel,
Sure, let me see it and I resolve the conflicts.

What are you going to do with this plugin?

[ArielCabib]

I figured out that since there are so many nice pull requests to https://github.com/exebetche/vlsub but none is merged, I can fork and merge them. Seems like the original repo is kind of abandoned and unresponsive.
And I already merged your pull request. Please tell me if everything is behaving as you expect.

[porg]

Hi, today I myself discovered the handy plugin vlsub (v0.11.1) which shipped pre-installed in VLC 3.0.18 Vetinari on macOS 11.7.2 Big Sur.

I too would prefer to rename files to the 2 letter code (ISO 639-1) instead of the 3 letter code (ISO 639-2).

Configuration > Display language code in file name: As of this version still has only Yes and No, instead of this clever proposal to choose Yes (3 letter codes) and Yes (2 letter codes).

Any news on why this pull request was not accepted and did not make it into the official version (as pre-installed in VLC) ?

[adrianparisi]

I never get any kind of feedback for this PR so I end up using a custom version of the addon with this feature included.