SED-4488 Poor performance of the steps table when filtering by statuses

[david-stephan]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @david-stephan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a performance issue (SED-4488) related to filtering the steps table by statuses. It updates a core dependency version and refines the test case filtering logic within the report nodes, specifically ensuring that filtering by test cases is only applied when valid test case data is present and handling the list type appropriately for the filter operation.

Highlights

• Dependency Version Update: The step-framework.version in pom.xml has been updated from 0.0.0-25-SNAPSHOT to 0.0.0-SED-4488-SNAPSHOT, likely aligning with the current task or development branch.
• Improved Test Case Filtering Logic: The ReportNodesFilter.java file now includes an additional check to ensure the testcases parameter is not empty before applying the filter. Additionally, the testcases list is now explicitly converted to List<Object> using new ArrayList<>(parameters.getTestcases()) before being used in the Filters.in method, which might address type safety or mutability concerns.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a performance issue in the steps table filtering. The main change involves adding a check to ensure the list of test cases is not empty before creating a filter, which is a good improvement. I've also suggested a small refactoring to improve code clarity and avoid redundant method calls.

[gemini-code-assist]

To improve readability and avoid calling parameters.getTestcases() multiple times, it's better to store its result in a local variable. In the current implementation, getTestcases() is called three times within this block, which can be inefficient and makes the code harder to read.

			List<String> testcasesList = parameters.getTestcases();
			if(testcasesList != null && !testcasesList.isEmpty()) {
				List<Object> testcases = new ArrayList<>(testcasesList);
				fragments.add(Filters.in("customAttributes.TestCase", testcases));
			}