Conversation
IsaacG
added
x:size/large
glennj
approved these changes
Feb 17, 2026
exercises/practice/prism/prism.awk
Outdated
| @@ -0,0 +1,8 @@ | |||
| # The first line of input is the starting x, y and angle. | |||
| # Any remaining input is the prisms: x, y, angle and ID. | |||
Contributor
There was a problem hiding this comment.
Can we put ID as the first field please?
Suggested change
| # Any remaining input is the prisms: x, y, angle and ID. | |
| # Any remaining input is the prisms: ID, x, y, and refraction angle. |
Comment on lines
37
to
39
| 0 -10 0 3 | ||
| -10 0 0 1 | ||
| 10 0 0 2 |
Contributor
There was a problem hiding this comment.
Any reason why these aren't sorted by ID?
Member
Author
There was a problem hiding this comment.
This matches the problem spec. I believe there was a misunderstanding in that PR that resulted in randomized prism order here. We can correct it but it should probably be done in the problem spec.
Contributor
There was a problem hiding this comment.
It doesn't matter how they appear in the test file, the code should find the next point on the path. I don't think we need to slavishly follow the canonical data for this, let's make it easier to read.
Contributor
|
Thanks Isaac! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.