Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| (test-equal? "Smallest abundant number" | ||
| (classify 12) | ||
| 'abundant) | ||
| (test-exn "zero is rejected" |
There was a problem hiding this comment.
This seems like an unfortunate addition since it will break existing solutions and isn't an interesting case.
There was a problem hiding this comment.
I can mark the input validation tests as not included since they technically weren’t until I added them here. It’s not a big deal to me to remove them as long as they are marked as not included in the toml.
| (test-equal? "Large abundant number" | ||
| (classify 33550335) | ||
| 'abundant))) | ||
| (test-exn "negative integer is rejected" |
blakelewis
left a comment
blakelewis
left a comment
There was a problem hiding this comment.
I don't like the added input validation but I suppose that it's too late now.
2 participants
No description provided.