Refactor indentation checker and check for 2 spaces #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaeng
approved these changes
May 22, 2025
PatrickMcSweeny
force-pushed
the
indentation
branch
from
ea330a0 to
7839735
Compare
Contributor
Author
|
What else needs to be done so this can be merged? |
|
Now that the tests are passing? Nothing :) Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107. @kotp asked me to open a PR in this comment. The indentation checker currently just checks to see if the indentation for each line is not more than 2 spaces different than the line the line that proceeds it. This PR ensures that the difference in indentation is either two spaces or zero.
The PR also refactors the indentation checker to improve readability and performance based on the suggestion in this comment