Skip to content

Add missing say test cases from canonical data - #879

Closed
andyjiang9 wants to merge 1 commit into
exercism:mainfrom
andyjiang9:fix-855-say-missing-test-cases
Closed

Add missing say test cases from canonical data#879
andyjiang9 wants to merge 1 commit into
exercism:mainfrom
andyjiang9:fix-855-say-missing-test-cases

Conversation

@andyjiang9

Copy link
Copy Markdown

Fixes #855.

The say practice exercise test suite was missing four cases that exist in the problem-specifications canonical data:

Description Input Expected
thirty 30 thirty
ninety-nine 99 ninety-nine
two hundred 200 two hundred
nine hundred ninety-nine 999 nine hundred ninety-nine

Changes

  • Added the four cases to SayTest.scala in canonical order, marked pending to match the existing convention.
  • Synced their UUIDs into .meta/tests.toml.

Verification

  • configlet sync --exercise say --tests reports "The say exercise has up-to-date tests!" (the tests.toml matches configlet's generated output exactly).
  • configlet lint passes.
  • bin/test say passes — the reference solution in .meta/Example.scala already handles all four cases, so all 19 tests are green.

Scope is limited to the single say exercise per the contribution guidelines.

The say test suite was missing four cases that exist in the
problem-specifications canonical data: "thirty" (30), "ninety-nine" (99),
"two hundred" (200) and "nine hundred ninety-nine" (999).

Add the four cases to SayTest.scala (marked pending, matching the
existing convention) and sync their UUIDs into .meta/tests.toml.

The reference solution in .meta/Example.scala already handles all four;
verified all 19 tests pass via bin/test.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions

Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions Bot closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Say exercise: Test suite is missing cases from canonical-data.json

1 participant