Add missing say test cases from canonical data - #879
Conversation
The say test suite was missing four cases that exist in the problem-specifications canonical data: "thirty" (30), "ninety-nine" (99), "two hundred" (200) and "nine hundred ninety-nine" (999). Add the four cases to SayTest.scala (marked pending, matching the existing convention) and sync their UUIDs into .meta/tests.toml. The reference solution in .meta/Example.scala already handles all four; verified all 19 tests pass via bin/test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
Fixes #855.
The
saypractice exercise test suite was missing four cases that exist in the problem-specifications canonical data:thirtythirtyninety-nineninety-ninetwo hundredtwo hundrednine hundred ninety-ninenine hundred ninety-nineChanges
SayTest.scalain canonical order, markedpendingto match the existing convention..meta/tests.toml.Verification
configlet sync --exercise say --testsreports "Thesayexercise has up-to-date tests!" (thetests.tomlmatches configlet's generated output exactly).configlet lintpasses.bin/test saypasses — the reference solution in.meta/Example.scalaalready handles all four cases, so all 19 tests are green.Scope is limited to the single
sayexercise per the contribution guidelines.