Skip to content

phone-number: return null on invalid input - #568

Open
keiravillekode wants to merge 1 commit into
exercism:mainfrom
keiravillekode:phone-number-comment
Open

phone-number: return null on invalid input#568
keiravillekode wants to merge 1 commit into
exercism:mainfrom
keiravillekode:phone-number-comment

Conversation

@keiravillekode

@keiravillekode keiravillekode commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Remove interface version check in bin/.test-in-docker

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but this would have been a good opportunity for @norwd to discuss this in the forums, as indicated in the README, and get their first contribution, and for the work that started on #567 to be continued.

I wonder if we should let them work on this, or if it is urgent enough for us to take over?

Remove interface version check in bin/.test-in-docker
@keiravillekode

Copy link
Copy Markdown
Contributor Author

There was an unrelated problem that bin/.test-in-docker was checking for version 2. Fixing that is the "urgent" part: it blocks any PRs on this track.

@kotp

kotp commented Aug 10, 2026

Copy link
Copy Markdown
Member

There was an unrelated problem that bin/.test-in-docker was checking for version 2. Fixing that is the "urgent" part: it blocks any PRs on this track.

Unrelated then should at a minimum be a different commit, but I would argue having unrelated things in a pull request would either make the pull request be titled with an "and" which often indicates it should be two pull requests, or perhaps the unrelated should be its own thing.

This way if one is reverted, the other remains.

Let's fix the urgent part that is blocking you be its own thing, and I can help you get that over the line immediately, while allowing a potentially new contributor have their moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants