phone-number: return null on invalid input - #568
Conversation
2073af0 to
7f7464b
Compare
kotp
left a comment
There was a problem hiding this comment.
Approving, but this would have been a good opportunity for @norwd to discuss this in the forums, as indicated in the README, and get their first contribution, and for the work that started on #567 to be continued.
I wonder if we should let them work on this, or if it is urgent enough for us to take over?
Remove interface version check in bin/.test-in-docker
7f7464b to
7fbe619
Compare
|
There was an unrelated problem that |
Unrelated then should at a minimum be a different commit, but I would argue having unrelated things in a pull request would either make the pull request be titled with an "and" which often indicates it should be two pull requests, or perhaps the unrelated should be its own thing. This way if one is reverted, the other remains. Let's fix the urgent part that is blocking you be its own thing, and I can help you get that over the line immediately, while allowing a potentially new contributor have their moment. |
Remove interface version check in
bin/.test-in-docker