Skip to content

chores: add git version/commit in user agent header #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quentinalbertone merged 2 commits into from
Dec 4, 2025
Merged

chores: add git version/commit in user agent header #769

quentinalbertone merged 2 commits into from
Dec 4, 2025

Conversation

@quentinalbertone
Copy link
Contributor

@quentinalbertone quentinalbertone commented Dec 4, 2025

Description

Add more information about the client user-agent in the cli

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

$> EXOSCALE_TRACE=1 ./exo c i ls
>>> Operation: list-zones
GET /v2/zone HTTP/1.1
Host: api-ch-gva-2.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:35 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"zones":[{"name":"ch-gva-2","api-endpoint":"https://api-ch-gva-2.exoscale.com/v2","id":"1747ef5e-5451-41fd-9f1a-58913bae9702","sos-endpoint":"https://sos-ch-gva-2.exo.io"},{"name":"ch-dk-2","api-endpoint":"https://api-ch-dk-2.exoscale.com/v2","id":"381d0a95-ed4a-4ad9-b41c-b97073c1a433","sos-endpoint":"https://sos-ch-dk-2.exo.io"},{"name":"at-vie-1","api-endpoint":"https://api-at-vie-1.exoscale.com/v2","id":"b0fcd72f-47ad-4779-a64f-fe4de007ec72","sos-endpoint":"https://sos-at-vie-1.exo.io"},{"name":"de-fra-1","api-endpoint":"https://api-de-fra-1.exoscale.com/v2","id":"de88c980-78f6-467c-a431-71bcc88e437f","sos-endpoint":"https://sos-de-fra-1.exo.io"}]}
----------------------------------------------------------------------
>>> Operation: list-zones
GET /v2/zone HTTP/1.1
Host: api-ch-gva-2.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


>>> Operation: list-zones
GET /v2/zone HTTP/1.1
Host: api-ch-gva-2.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


>>> Operation: list-zones
GET /v2/zone HTTP/1.1
Host: api-ch-gva-2.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


>>> Operation: list-zones
GET /v2/zone HTTP/1.1
Host: api-ch-gva-2.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:35 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"zones":[{"name":"ch-gva-2","api-endpoint":"https://api-ch-gva-2.exoscale.com/v2","id":"1747ef5e-5451-41fd-9f1a-58913bae9702","sos-endpoint":"https://sos-ch-gva-2.exo.io"},{"name":"ch-dk-2","api-endpoint":"https://api-ch-dk-2.exoscale.com/v2","id":"381d0a95-ed4a-4ad9-b41c-b97073c1a433","sos-endpoint":"https://sos-ch-dk-2.exo.io"},{"name":"at-vie-1","api-endpoint":"https://api-at-vie-1.exoscale.com/v2","id":"b0fcd72f-47ad-4779-a64f-fe4de007ec72","sos-endpoint":"https://sos-at-vie-1.exo.io"},{"name":"de-fra-1","api-endpoint":"https://api-de-fra-1.exoscale.com/v2","id":"de88c980-78f6-467c-a431-71bcc88e437f","sos-endpoint":"https://sos-de-fra-1.exo.io"}]}
----------------------------------------------------------------------
>>> Operation: list-instances
GET /v2/instance HTTP/1.1
Host: api-ch-dk-2.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:35 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"zones":[{"name":"ch-gva-2","api-endpoint":"https://api-ch-gva-2.exoscale.com/v2","id":"1747ef5e-5451-41fd-9f1a-58913bae9702","sos-endpoint":"https://sos-ch-gva-2.exo.io"},{"name":"ch-dk-2","api-endpoint":"https://api-ch-dk-2.exoscale.com/v2","id":"381d0a95-ed4a-4ad9-b41c-b97073c1a433","sos-endpoint":"https://sos-ch-dk-2.exo.io"},{"name":"at-vie-1","api-endpoint":"https://api-at-vie-1.exoscale.com/v2","id":"b0fcd72f-47ad-4779-a64f-fe4de007ec72","sos-endpoint":"https://sos-at-vie-1.exo.io"},{"name":"de-fra-1","api-endpoint":"https://api-de-fra-1.exoscale.com/v2","id":"de88c980-78f6-467c-a431-71bcc88e437f","sos-endpoint":"https://sos-de-fra-1.exo.io"}]}
----------------------------------------------------------------------
>>> Operation: list-instances
GET /v2/instance HTTP/1.1
Host: api-ch-gva-2.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:35 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"zones":[{"name":"ch-gva-2","api-endpoint":"https://api-ch-gva-2.exoscale.com/v2","id":"1747ef5e-5451-41fd-9f1a-58913bae9702","sos-endpoint":"https://sos-ch-gva-2.exo.io"},{"name":"ch-dk-2","api-endpoint":"https://api-ch-dk-2.exoscale.com/v2","id":"381d0a95-ed4a-4ad9-b41c-b97073c1a433","sos-endpoint":"https://sos-ch-dk-2.exo.io"},{"name":"at-vie-1","api-endpoint":"https://api-at-vie-1.exoscale.com/v2","id":"b0fcd72f-47ad-4779-a64f-fe4de007ec72","sos-endpoint":"https://sos-at-vie-1.exo.io"},{"name":"de-fra-1","api-endpoint":"https://api-de-fra-1.exoscale.com/v2","id":"de88c980-78f6-467c-a431-71bcc88e437f","sos-endpoint":"https://sos-de-fra-1.exo.io"}]}
----------------------------------------------------------------------
>>> Operation: list-instances
GET /v2/instance HTTP/1.1
Host: api-de-fra-1.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:35 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"zones":[{"name":"ch-gva-2","api-endpoint":"https://api-ch-gva-2.exoscale.com/v2","id":"1747ef5e-5451-41fd-9f1a-58913bae9702","sos-endpoint":"https://sos-ch-gva-2.exo.io"},{"name":"ch-dk-2","api-endpoint":"https://api-ch-dk-2.exoscale.com/v2","id":"381d0a95-ed4a-4ad9-b41c-b97073c1a433","sos-endpoint":"https://sos-ch-dk-2.exo.io"},{"name":"at-vie-1","api-endpoint":"https://api-at-vie-1.exoscale.com/v2","id":"b0fcd72f-47ad-4779-a64f-fe4de007ec72","sos-endpoint":"https://sos-at-vie-1.exo.io"},{"name":"de-fra-1","api-endpoint":"https://api-de-fra-1.exoscale.com/v2","id":"de88c980-78f6-467c-a431-71bcc88e437f","sos-endpoint":"https://sos-de-fra-1.exo.io"}]}
----------------------------------------------------------------------
>>> Operation: list-instances
GET /v2/instance HTTP/1.1
Host: api-at-vie-1.exoscale.com
Authorization: XXXXXXXXXXXXXXXXX
User-Agent: exocli/v0.0.1-test-quentin/3037c14a egoscale/v3.1.30 (go1.25.4 X:nodwarf5; linux/amd64)


<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:36 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"instances":[]}
----------------------------------------------------------------------
<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:36 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"instances":[]}
----------------------------------------------------------------------
<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:36 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"instances":[]}
----------------------------------------------------------------------
<<< HTTP/2.0 200 OK
Connection: close
Content-Type: application/json; charset=utf-8
Date: Thu, 04 Dec 2025 08:12:36 GMT
Referrer-Policy: no-referrer-when-downgrade
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload
X-Content-Type-Options: nosniff always
X-Xss-Protection: 1; mode=block always

{"instances":[]}
----------------------------------------------------------------------

@quentinalbertone quentinalbertone requested a review from a team December 4, 2025 08:25
@quentinalbertone quentinalbertone marked this pull request as draft December 4, 2025 09:11
@quentinalbertone quentinalbertone force-pushed the sc-94988/egoscale-standardised-user-agent branch from 3037c14 to 259bfb7 Compare December 4, 2025 09:30
@quentinalbertone quentinalbertone marked this pull request as ready for review December 4, 2025 09:34
@quentinalbertone quentinalbertone merged commit 2efc648 into master Dec 4, 2025
2 checks passed
@quentinalbertone quentinalbertone deleted the sc-94988/egoscale-standardised-user-agent branch December 4, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierre-emmanuelJ pierre-emmanuelJ pierre-emmanuelJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quentinalbertone @pierre-emmanuelJ