aiservices: improve delete behavior for models and deployments #772
+98
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobajagi
reviewed
Dec 12, 2025
| if !c.Force { | ||
| return err | ||
| } | ||
| fmt.Fprintf(os.Stderr, "warning: %s not found.\n", deploymentStr) |
Contributor
There was a problem hiding this comment.
Not always correct: https://github.com/exoscale/egoscale/blob/master/v3/operations.go#L28
Contributor
There was a problem hiding this comment.
You can just print error, eg. fmt.Fprintf(os.Stderr, "warning: %w\n", err)
sauterp
approved these changes
Dec 12, 2025
kobajagi
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut story: sc-157181:
exo compute instance delete ...)Checklist
Testing
It works on my machine