feat: add a warning in case the object doesn't exists before generating the presign url #773
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the presign url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It happened sometimes that when I want to generate a presigned url, I make a typo in the object name / path.
And it is only when I sent the link to someone or when I want to download the object, that I notice that the URL returns 404.
I would prefer to notice it when I generate the URL.
This MR adds a warning message when the object doesn't exists. For the moment, only a warning, I could return the error and no presigned url at all if you prefer.
Checklist
(For exoscale contributors)
Testing