feat: ✨ add rootdirectory option to configure custom public folder root for __ENV.js#193
Open
uberwild wants to merge 2 commits intoexpatfile:1.xfrom
Open
feat: ✨ add rootdirectory option to configure custom public folder root for __ENV.js#193uberwild wants to merge 2 commits intoexpatfile:1.xfrom
uberwild wants to merge 2 commits intoexpatfile:1.xfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my case, next-runtime-env was always resolving the output path relative to process.cwd() and assuming public/ exists at that level. This caused __ENV.js to be written to the wrong location.
This merge request adds support for a new rootdirectory option to configureRuntimeEnv, allowing consumers to customize the root path where the public/__ENV.js file is written.