You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Phillip9587 I don't think I fully read that PR but took a quick look just now and I think we should wait on it. The code scanning had some comments (first time seeing that in action, and I think it is actually some good feedback to discuss) and we are shooting to release this asap. It has been dragging on too long and we had a sync on today's working session to try and see what we can land and what might need to go into the next patch. I can keep that tab open for tomorrow and try and give it a review, but I think if you are alright with it maybe we can wait for that one for the next patch (which we can make high priority)?
please double check in detail #596 as it is included in this release and I was the only reviewer
I am not sure I am a big fan of all the optional chaining vs just making sure we always make an options object, but I don't see anything worth blocking over. We can decide if we wanted to take a different approach in the future without any user impact so it is all good imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
--bailfrom test script by @Phillip9587 in test: remove--bailfrom test script #583lcovonlyreporter for thetest-ciscript by @Phillip9587 in ci: uselcovonlyreporter for thetest-ciscript #584New Contributors
Full Changelog: v2.1.0...master