Open
Conversation
Co-authored-by: Jon Church <me@jonchurch.com>
d4c1908 to
ccf5c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the work by @jonchurch in #606 and previous PRs listed in #22 (comment). Dicussion on this topic happened in #22.
There is one remaining point we need to figure out:
parsefunctionThis PR in its current state passes the body as
Bufferand the charset to the user provided parse function:With this approach we loose the
iconv-litedecoding and the users would need to do that themselves . Should we instead already decode the body and pass it as string without the charset? Like:I think the most common use-case for the generic parser will be a custom string parser like parsing
csvoryaml. Not some custom binary format. As alternative we could expose an option which switches between passing a Buffer or a already decoded string to the parse function.cc @ctcpip @jonchurch @UlisesGascon @bjohansebas