Skip to content

feat(array): Entry API (Issue #525) #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kakserpom wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(array): Entry API (Issue #525) #611

kakserpom wants to merge 4 commits into from
+1,180 −2

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Dec 18, 2025

Implements #525

@kakserpom kakserpom force-pushed the 525_zend_ht_entry branch 2 times, most recently from a3ec65c to 1f5b882 Compare December 18, 2025 14:30
ptondereau
ptondereau reviewed Dec 18, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me but CI is red

@coveralls
Copy link

coveralls commented Dec 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20414114054

Details

  • 62 of 100 (62.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 37.102%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/array/mod.rs 11 16 68.75%
src/types/array/entry.rs 51 84 60.71%
Totals Coverage Status
Change from base Build 20412913109: 1.0%
Covered Lines: 1759
Relevant Lines: 4741
💛 - Coveralls

ptondereau
ptondereau previously approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptondereau ptondereau ptondereau left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kakserpom @coveralls @ptondereau