Skip to content

Added ability to update stars rating outside the component #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fighterinthewind wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ability to update stars rating outside the component #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
337e837
- Adding ability to update stars rating from outside
fighterinthewind Jul 13, 2018
d2bdf18
- Removed debuggers
fighterinthewind Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/rating.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ export default class Rating extends PureComponent {
}
}


componentWillReceiveProps(nextProps) {
this.animate(nextProps.initial, false)()
Copy link
Owner

@f0rr0 f0rr0 Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calling setState here should be enough ?

Copy link
Author

@fighterinthewind fighterinthewind Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should not be enough.
It works exactly how I implemented it.

}

getSelectedOpacity = index =>
this.animatedValues[index].interpolate({
inputRange: [0, 1],
Expand All @@ -117,15 +122,17 @@ export default class Rating extends PureComponent {

animatedValues = initializeAnimatedValues(this.props.max, this.props.initial)

animate = curr => () => {
animate = (curr, shouldReload) => () => {
const { config, stagger, onChange, onAnimationComplete } = this.props
const animations = createAnimations(config, this.animatedValues, this.state.selected, curr)
this.setState(
() => ({
selected: curr
}),
() => {
onChange(this.state.selected)
if (shouldReload) {
onChange(this.state.selected)
}
Animated.stagger(stagger, animations).start(() => onAnimationComplete(this.state.selected))
}
)
Expand All @@ -135,7 +142,7 @@ export default class Rating extends PureComponent {
<TouchableWithoutFeedback
disabled={!this.props.editable}
key={index}
onPress={this.animate(index + 1)}
onPress={this.animate((index + 1), true)}
>
<View style={this.props.starStyle}>
<View style={styles.imageContainer}>
Expand Down