Add getters for yaw, azimuth and elevation by AbbasReads · Pull Request #2499 · f3d-app/f3d

AbbasReads · 2025-10-07T09:08:43Z

Added getters for yaw, azimuth and elevation, and python bindings for them

Issue ticket number and link if any

Checklist for finalizing the PR

I have performed a self-review of my code
I have added tests for new features and bugfixes
I have added documentation for new features
If it is a modifying the libf3d API, I have updated bindings
If it is a modifying the .github/workflows/versions.json, I have updated timestamp

github-actions · 2025-10-07T09:08:51Z

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

codecov · 2025-10-08T05:58:00Z

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.48%. Comparing base (e3651cc) to head (7d82ce5).
⚠️ Report is 19 commits behind head on master.

Files with missing lines	Patch %	Lines
library/src/camera_impl.cxx	92.85%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
+ Coverage   96.43%   96.48%   +0.04%     
==========================================
  Files         138      140       +2     
  Lines       12047    12192     +145     
==========================================
+ Hits        11618    11763     +145     
  Misses        429      429

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mwestphal · 2025-10-29T09:06:26Z

please rebase on latest master

… test

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

resolved conflicts

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

…alization

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

…d python bindings tests

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

…assertions to use pytest.approx for floating-point comparisons

…d azimuth checks

…tion and azimuth checks

mwestphal · 2025-10-31T12:05:45Z

  [[nodiscard]] virtual camera_state_t getState() const = 0;
  /** Get the complete state of the camera into the provided arg */
  virtual void getState(camera_state_t& state) const = 0;
-


do not remove

mwestphal · 2025-10-31T12:07:04Z

    vector3_t orthogonalizedUp;
    cam->GetViewUp(orthogonalizedUp.data());
-    static constexpr double EPSILON = 128 * std::numeric_limits<double>::epsilon();
    for (size_t i = 0; vtkMath::Norm(orthogonalizedUp.data()) < EPSILON && i < up.size(); i++)


Suggested change

for (size_t i = 0; vtkMath::Norm(orthogonalizedUp.data()) < EPSILON && i < up.size(); i++)

for (size_t i = 0; vtkMath::Norm(orthogonalizedUp.data()) < ::EPSILON && i < up.size(); i++)

mwestphal · 2025-10-31T12:07:37Z

+  vtkMath::Normalize(dir.data());
+  vtkMath::Normalize(up);
+
+  if (vtkMath::Norm(dir.data()) <= EPSILON)


Suggested change

if (vtkMath::Norm(dir.data()) <= EPSILON)

if (vtkMath::Norm(dir.data()) <= ::EPSILON)

mwestphal · 2025-10-31T12:08:04Z

+  }
+
+  // Project forward vector onto up vector
+  if (abs(vtkMath::AngleBetweenVectors(dir.data(), up) - vtkMath::Pi() / 2) <= EPSILON)


Suggested change

if (abs(vtkMath::AngleBetweenVectors(dir.data(), up) - vtkMath::Pi() / 2) <= EPSILON)

if (abs(vtkMath::AngleBetweenVectors(dir.data(), up) - vtkMath::Pi() / 2) <= ::EPSILON)

mwestphal · 2025-10-31T12:08:14Z

+
+  // Projection of forward vector along the plane perpendicular to up vector
+  vtkMath::Subtract(dir, projectedAlongUp, projected);
+  if (vtkMath::Norm(projected.data()) <= EPSILON)


Suggested change

if (vtkMath::Norm(projected.data()) <= EPSILON)

if (vtkMath::Norm(projected.data()) <= ::EPSILON)

mwestphal · 2025-10-31T12:09:32Z

Please also update F3DEmscriptenBindings.cxx and add a test in webassembly/testing/test_camera.js

mwestphal · 2025-10-31T12:10:02Z

+
+  if (vtkMath::Norm(dir.data()) <= EPSILON)
+  {
+    return 0;


please add a test covering this

mwestphal · 2025-10-31T12:10:18Z

+  vtkMath::Subtract(dir, projectedAlongUp, projected);
+  if (vtkMath::Norm(projected.data()) <= EPSILON)
+  {
+    return 0;


please add a test covering this

mwestphal

changes needed

mwestphal · 2025-11-08T09:50:26Z

Need any help moving forward @AbbasReads ?

…nd update tests

github-actions · 2025-11-10T21:09:18Z

Style Checks CI failed:

diff --git a/library/testing/TestSDKCamera.cxx b/library/testing/TestSDKCamera.cxx
index c9fccdb..eacec45 100644
--- a/library/testing/TestSDKCamera.cxx
+++ b/library/testing/TestSDKCamera.cxx
@@ -179,7 +179,8 @@ int TestSDKCamera([[maybe_unused]] int argc, [[maybe_unused]] char* argv[])
   // }
 
   // cam.yaw(90.0);
-  // if (!compareDouble(cam.getYaw(), 90.0, 1e-6) || !compareDouble(cam.getElevation(), 0.0, 1e-6) ||
+  // if (!compareDouble(cam.getYaw(), 90.0, 1e-6) || !compareDouble(cam.getElevation(), 0.0, 1e-6)
+  // ||
   //   !compareDouble(cam.getAzimuth(), 90.0, 1e-6))
   // {
   //   std::cerr << "After yaw(90): unexpected orientation\n"
@@ -190,7 +191,8 @@ int TestSDKCamera([[maybe_unused]] int argc, [[maybe_unused]] char* argv[])
   // }
 
   // cam.elevation(45.0);
-  // if (!compareDouble(cam.getYaw(), 90.0, 1e-6) || !compareDouble(cam.getElevation(), 45.0, 1e-6) ||
+  // if (!compareDouble(cam.getYaw(), 90.0, 1e-6) || !compareDouble(cam.getElevation(), 45.0, 1e-6)
+  // ||
   //   !compareDouble(cam.getAzimuth(), 90.0, 1e-6))
   // {
   //   std::cerr << "After elevation(45): unexpected orientation\n"
@@ -201,7 +203,8 @@ int TestSDKCamera([[maybe_unused]] int argc, [[maybe_unused]] char* argv[])
   // }
 
   // cam.azimuth(90);
-  // if (!compareDouble(cam.getYaw(), 180.0, 1e-6) || !compareDouble(cam.getElevation(), 0.0, 1e-6) ||
+  // if (!compareDouble(cam.getYaw(), 180.0, 1e-6) || !compareDouble(cam.getElevation(), 0.0, 1e-6)
+  // ||
   //   !compareDouble(cam.getAzimuth(), 180.0, 1e-6))
   // {
   //   std::cerr << "After azimuth(90): unexpected orientation\n"
diff --git a/webassembly/testing/test_camera.js b/webassembly/testing/test_camera.js
index a108953..3863df5 100644
--- a/webassembly/testing/test_camera.js
+++ b/webassembly/testing/test_camera.js
@@ -48,8 +48,14 @@ const settings = {
     console.log("Yaw:", camera.getYaw());
     console.log("Elevation:", camera.getElevation());
 
-    utils.assert(Math.abs(camera.getYaw() - 45) < 0.01, "Yaw should be 45 after yaw(45)");
-    utils.assert(Math.abs(camera.getElevation()) < 0.01, "Elevation should remain 0");
+    utils.assert(
+      Math.abs(camera.getYaw() - 45) < 0.01,
+      "Yaw should be 45 after yaw(45)",
+    );
+    utils.assert(
+      Math.abs(camera.getElevation()) < 0.01,
+      "Elevation should remain 0",
+    );
 
     // Test elevation rotation
     // camera.resetToDefault();

mwestphal · 2025-11-29T14:29:35Z

Hi @AbbasReads , still wokring on this ?

mwestphal added the ci:full label Oct 8, 2025

mwestphal reviewed Oct 8, 2025

View reviewed changes

Comment thread library/src/camera_impl.cxx Outdated

mwestphal reviewed Oct 18, 2025

View reviewed changes

Comment thread library/src/camera_impl.cxx Outdated

AbbasReads and others added 24 commits October 30, 2025 15:43

feat: Add yaw, azimuth, and elevation methods to camera implementation

a52dc5c

Update camera tests for yaw, elevation, and add getAzimuth method and…

b71e34f

… test

Update library/testing/TestSDKCamera.cxx

00e550d

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Update library/testing/TestSDKCamera.cxx

bbd46ee

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Update library/testing/TestSDKCamera.cxx

9e2e7b7

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Update library/testing/TestSDKCamera.cxx

1d39960

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Update library/src/camera_impl.cxx

aca1007

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Update library/src/camera_impl.cxx

b6da2d2

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Refactor camera angle methods for improved clarity

ab838df

resolved conflicts

Update library/testing/TestSDKCamera.cxx

52279de

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Update library/testing/TestSDKCamera.cxx

a836f29

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Enhance camera angle method documentation and fix test variable initi…

e6f0368

…alization

Add camera getter methods to Python bindings

bc64599

Update library/public/camera.h

02d04fd

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Update library/public/camera.h

5c99fa5

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Add combined camera movement tests for yaw, elevation, and azimuth an…

7ba9b3d

…d python bindings tests

Refactor getAzimuth method to call getYaw directly =

822087b

Update library/public/camera.h

eabbfe3

Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>

Edited getAzimuth documentation

7e93c2b

Fix formatting in getYaw documentation comment

894f799

Fix formatting in camera_impl.cxx and test_camera.py

2d5193b

Printing test values for debugging

e4e6e70

Refactor compareDouble for better tolerance handling and update test …

a832577

…assertions to use pytest.approx for floating-point comparisons

Update compareDouble tolerance in TestSDKCamera in yaw, elevation, an…

2263f9d

…d azimuth checks

AbbasReads added 7 commits October 30, 2025 15:45

Update elevation test in TestSDKCamera to check for correct values

cc37d31

testing

d45f248

debugging

b87b08b

Fix yaw calculation in camera_impl and update TestSDKCamera for eleva…

5a618c6

…tion and azimuth checks

Style edit

e28eb8f

Refactor EPSILON definition and improve yaw calculation in camera_impl

8fd4d30

Small changes

be4a6d7

AbbasReads force-pushed the getters branch from 9781923 to be4a6d7 Compare October 30, 2025 13:28

Remove repeated yaw, azimuth, and elevation methods from camera

2dc8e39

mwestphal reviewed Oct 31, 2025

View reviewed changes

mwestphal requested changes Oct 31, 2025

View reviewed changes

Add getYaw, getAzimuth, and getElevation methods to camera bindings a…

7d82ce5

…nd update tests

error in tests

fe9c462

mwestphal added triage:stalled and removed ci:full labels Dec 6, 2025

	for (size_t i = 0; vtkMath::Norm(orthogonalizedUp.data()) < EPSILON && i < up.size(); i++)
	for (size_t i = 0; vtkMath::Norm(orthogonalizedUp.data()) < ::EPSILON && i < up.size(); i++)

	if (vtkMath::Norm(dir.data()) <= EPSILON)
	if (vtkMath::Norm(dir.data()) <= ::EPSILON)

	if (abs(vtkMath::AngleBetweenVectors(dir.data(), up) - vtkMath::Pi() / 2) <= EPSILON)
	if (abs(vtkMath::AngleBetweenVectors(dir.data(), up) - vtkMath::Pi() / 2) <= ::EPSILON)

	if (vtkMath::Norm(projected.data()) <= EPSILON)
	if (vtkMath::Norm(projected.data()) <= ::EPSILON)

Uh oh!

Conversation

AbbasReads commented Oct 7, 2025

Added getters for yaw, azimuth and elevation, and python bindings for them

Issue ticket number and link if any

Checklist for finalizing the PR

Uh oh!

github-actions Bot commented Oct 7, 2025

Uh oh!

Uh oh!

codecov Bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mwestphal commented Oct 29, 2025

Uh oh!

mwestphal Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mwestphal Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mwestphal Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mwestphal Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mwestphal Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mwestphal Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwestphal Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mwestphal Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

mwestphal commented Nov 8, 2025

Uh oh!

github-actions Bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwestphal commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Oct 8, 2025 •

edited

Loading

mwestphal Oct 31, 2025 •

edited

Loading

github-actions Bot commented Nov 10, 2025 •

edited

Loading