Open
Conversation
isabellacgmsa
commented
Aug 8, 2022
| const { userId } = res.locals.user; | ||
| const { safeNoteId } = req.params; | ||
| await safeNoteService.deleteSafeNote(parseInt(safeNoteId), userId); | ||
| res.sendStatus(200); |
Author
There was a problem hiding this comment.
Seria legal ter uma mensagem de sucesso
isabellacgmsa
commented
Aug 8, 2022
Comment on lines
-8
to
-9
| //const validation = authSchemas.tokenSchema.validate(authorization); | ||
| //if (validation.error) return res.status(403); |
Author
There was a problem hiding this comment.
Lembra só de apagar os comentários
isabellacgmsa
commented
Aug 8, 2022
Author
isabellacgmsa
left a comment
isabellacgmsa
left a comment
There was a problem hiding this comment.
Oii Filipe tudo bem?
Passando aqui pra te dar um feedback, ficou muito bom seu projeto!
Mandou bem na arquitetura!!
Lembra sempre de apagar os comentários quando finalizar o código!
Só uma dica, para ajudar quem for rodar seria legal ter um .env.example para termos uma ideia de quais variáveis de ambiente precisam ser configuradas.
Qualquer dúvida, só me mandar uma mensagem pelo discord <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.