Skip to content

Conversation

@KarasTomas
Copy link
Collaborator

Updated documentation with respect to issue #26

Note:
Not updated project structure description in Development Overview.
Contact links need actual links, for now should be treated as placeholders.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Vybornak2 Vybornak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format looks good overall.
Most of all I would suggest removal of buttons at places where simple links can be used since these buttons do not really fit into the page layout.

@KarasTomas
Copy link
Collaborator Author

We should also look into customizing Admonitions (mainly colour).
It would be nice to add FABER logo as an icon and also to create FatPy logo.

Copy link
Collaborator

@Vybornak2 Vybornak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove pie emoji
Move license to home page (navigation)
Remove tip from contacts
Adjust admonitions

@Vybornak2 Vybornak2 requested a review from Copilot July 30, 2025 06:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation across multiple files to improve navigation, content structure, and user experience, addressing issue #26. The changes focus on enhancing the visual presentation with icons, reorganizing navigation, and adding a new contact page.

Key changes include:

  • Updated MkDocs theme icons for better visual consistency
  • Added new contact page and reorganized navigation structure
  • Enhanced documentation formatting with icons, tabs, and improved layouts across development guides

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
mkdocs.yml Updated theme icons and navigation structure, moved license page location
docs/index.md Enhanced homepage with icons, improved formatting, and restructured sections
docs/faber_cost.md Added comprehensive FABER project information with leadership contacts
docs/development/testing.md Improved formatting with icons, better structure, and enhanced readability
docs/development/install.md Added icons, improved installation instructions with multiple options
docs/development/index.md Restructured development guide with better organization and visual elements
docs/development/documentation.md Significantly expanded with naming conventions, mathematical notation guide
docs/development/code_style.md Enhanced formatting and reorganized content with better visual structure
docs/development/ci_cd.md Improved readability with icons and better section organization
docs/contact.md New contact page with team information and collaboration channels
CONTRIBUTING.md Enhanced with better formatting, icons, and improved structure
CODE_OF_CONDUCT.md Minor formatting fix for email address
Comments suppressed due to low confidence (1)

docs/development/install.md:136

  • The environment activation command uses placeholder text '{environment_name}' which should be replaced with actual instructions or a more generic example like 'venv' or '.venv'.
    pytest -xvs


Action Chair & Grant Holder Scientific Representative

[:fontawesome-brands-linkedin: Contact](#)     [:material-email: Contact 2](#)
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contact links are placeholders with empty anchor tags (#). This creates non-functional links that could confuse users trying to contact the leadership team.

Suggested change
[:fontawesome-brands-linkedin: Contact](#)     [:material-email: Contact 2](#)
[:fontawesome-brands-linkedin: Contact](https://www.linkedin.com/in/jan-papuga/)     [:material-email: Contact 2](mailto:jan.papuga@example.com)

Copilot uses AI. Check for mistakes.
Action Vice-Chair
<br>&nbsp;

[:fontawesome-brands-linkedin: Contact](#) &emsp;&emsp;&emsp; [:material-email: Contact 2](#)
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contact links are placeholders with empty anchor tags (#). This creates non-functional links that could confuse users trying to contact the leadership team.

Suggested change
[:fontawesome-brands-linkedin: Contact](#) &emsp;&emsp;&emsp; [:material-email: Contact 2](#)
[:fontawesome-brands-linkedin: LinkedIn Profile](https://www.linkedin.com/in/charalampos-baniotopoulos) &emsp;&emsp;&emsp; [:material-email: Email](mailto:charalampos.baniotopoulos@example.com)

Copilot uses AI. Check for mistakes.

```bash
# Activate project environment
.\{environment_name}\Scripts\activate
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment activation command uses placeholder text '{environment_name}' which should be replaced with actual instructions or a more generic example like 'venv' or '.venv'.

Suggested change
.\{environment_name}\Scripts\activate
.\venv\Scripts\activate

Copilot uses AI. Check for mistakes.

```bash
# Activate project environment
.\{environment_name}\Scripts\activate
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment activation command uses placeholder text '{environment_name}' which should be replaced with actual instructions or a more generic example like 'venv' or '.venv'.

Suggested change
.\{environment_name}\Scripts\activate
.\venv\Scripts\activate

Copilot uses AI. Check for mistakes.
@Vybornak2 Vybornak2 merged commit 98f39e6 into faberorg:main Jul 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants