Skip to content

Key prop fix #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krilklem merged 2 commits into from
Dec 16, 2025
Merged

Key prop fix #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4663317
fix: Add key to accordion items, add message if no feedback has been …
krilklem Dec 16, 2025
3bb5176
chore: Lint
krilklem Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function App() {
<div className="app-nav__center"> We highlight what matters</div>
<div className="app-nav__actions">
{isSignedIn ? (
<Link to="/feedback">Past feedback</Link>
<Link to="/feedback">Feedback</Link>
) : (
<Link to="/create-user">Join Us</Link>
)}
Expand Down
47 changes: 16 additions & 31 deletions src/components/FeedbackGallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,41 +54,26 @@ export default function Feedback() {
return (
<>
{message && <p>{message}</p>}
<Accordion type="single" className="w-full" collapsible>
{allFeedback.map((item, index) => (
<AccordionItem value={`feedback-${index}`}>
<AccordionTrigger>{item.job_name}</AccordionTrigger>
<AccordionContent>
<ResultCard
jobDescription={item.job_description}
feedback={item.gen_feedback}
/>
</AccordionContent>
</AccordionItem>
))}
</Accordion>

{/* {allFeedback.length > 0 && (
<ul>
{allFeedback.length > 0 ? (
<Accordion type="single" className="w-full" collapsible>
{allFeedback.map((item, index) => (
<li key={index}>{item.job_name}
<ResultCard
jobDescription={item.job_description}
feedback={item.gen_feedback}
/>
</li>
))}

<Accordion type="single" collapsible>
<AccordionItem value="item-1">
<AccordionTrigger>Is it accessible?</AccordionTrigger>
<AccordionItem
key={`feedback-${index}`}
value={`feedback-${index}`}
>
<AccordionTrigger>{item.job_name}</AccordionTrigger>
<AccordionContent>
Yes. It adheres to the WAI-ARIA design pattern.
<ResultCard
jobDescription={item.job_description}
feedback={item.gen_feedback}
/>
</AccordionContent>
</AccordionItem>
</Accordion>
</ul>
)} */}
))}
</Accordion>
) : (
<p>You don't have any saved feedback yet...</p>
)}
</>
);
}