Optionally support DataContract in Mono/Unity#61
Optionally support DataContract in Mono/Unity#61Esam-Bustaty wants to merge 6 commits intofacebook-csharp-sdk:masterfrom
Conversation
src/SimpleJson/SimpleJson.cs
Outdated
There was a problem hiding this comment.
all #define prefix should be prefixed with SIMPLE_JSON_. Don't quite like the name alternate too. feel free to give suggestions.
There was a problem hiding this comment.
I can think of these possible names:
SIMPLE_JSON_CUSTOM_DATACONTRACT
SIMPLE_JSON_FIX_MISSING_DATACONTRACT
SIMPLE_JSON_REDEFINE_ATTRIBUTES
SIMPLE_JSON_CUSTOM_ATTRIBUTES
SIMPLE_JSON_FIX_MISSING_ATTRIBUTES
SIMPLE_JSON_FIX_MONO_MISSING_ATTRIBUTES
SIMPLE_JSON_NO_WCF
SIMPLE_JSON_FIX_MISSING_DATACONTRACT
There was a problem hiding this comment.
SIMPLE_JSON_REDEFINE_DATACONTRACT_ATTRIBUTES or SIMPLE_JSON_EMBED_DATACONTRACT_ATTRIBUTES.
There was a problem hiding this comment.
I'll vote for SIMPLE_JSON_REDEFINE_DATACONTRACT_ATTRIBUTES as i think the word "embed" is used when sticking something to the data itself, not classes or attributes, but both are fine.
There was a problem hiding this comment.
sure. go for it before I can merge
|
Did the rename, it's now |
src/SimpleJson/SimpleJson.cs
Outdated
src/SimpleJson/SimpleJson.cs
Outdated
There was a problem hiding this comment.
add
#if SIMPLE_JSON_INTERNAL
internal
#else
public
#endif
|
so, is this waiting for something from me? i want to make other pull requests, but as I'm new to github, I wanted to do them one by one, as each one is a separate feature, so if there is something that I can do to accelerate this, I'm happy to do, otherwise, how can I make other pull requests? maybe port again? how these things are usually done? |
|
will try merging and releasing this later tonight. The rule is not to update your master with your patches. This allows you to work on multiple features at the same time. Here is a good workflow from Nancy. https://github.com/NancyFx/Nancy/wiki/Git-Workflow |
2 participants
Mono doesn't implement the attributes DataContract/DataMember/IgnoreDataMember, so to be able to use them in Unity/Mono i added a define to implement them in SimpleJson namespace, just define ALTERNATE_DATACONTRACT to enable the alternate definition.