Allow deserialization of very large integers#75
Open
logiclrd wants to merge 1 commit intofacebook-csharp-sdk:masterfrom
Open
Allow deserialization of very large integers#75logiclrd wants to merge 1 commit intofacebook-csharp-sdk:masterfrom
logiclrd wants to merge 1 commit intofacebook-csharp-sdk:masterfrom
Conversation
…building a System.String of the number substring. Reworked the integer parsing path in SimpleJson.cs to try decimal and double parsers if long fails. This allows numbers such as long.MaxValue + 1M to be parsed (yielding a decimal instead of a long). Numbers too large for System.Decimal become System.Double (at, of course, a loss of precision). Added tests GivenNumberWithoutDecimalTooLargeForLongTypeIsDecimal and GivenNumberWithoutDecimalTooLargeForDecimalTypeIsDouble to JsonDecodeTypeTests.cs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was working on a PR for RestSharp, I was reading through the SimpleJson code and discovered that the way in which it parses integers might reject some syntactically-valid JSON documents. In particular, JSON allows for very large integer values to be specified (values large enough that a 64-bit integer cannot represent them) with no punctuation or exponentiation. These values would, in typical implementations, need to be represented as floating-point values (
double), but because they lack periods andesignifiers, the SimpleJson code will only attempt to parse them aslong. This means that the (valid) JSON string produced by(long.MaxValue + 1M).ToString()cannot be parsed. This PR addresses the issue (usingdecimaland thendoubleas fallbacks wherelongfails), and adds corresponding unit tests.