fix(vibe-tests): repair report build (core dist .js + esnext target)#3268
Open
cixzhang wants to merge 1 commit into
Open
fix(vibe-tests): repair report build (core dist .js + esnext target)#3268cixzhang wants to merge 1 commit into
cixzhang wants to merge 1 commit into
Conversation
The nightly report build (build-report.ts → deploy-report.ts Step 5) has been
failing since early June, independent of the target rename:
- The report Vite config aliased @astryxdesign/core subpath/root imports to
dist/**/index.mjs, but core's build emits .js (build:esm uses
--out-file-extension '.js' since the Babel CLI switch). Vite could not load
the modules → "Could not load .../dist/theme/index.mjs (ENOENT)".
- After fixing resolution, esbuild failed to transpile the bundled core to the
default es2020 target ("Transforming destructuring ... is not supported yet",
135 errors), because no build.target was set.
Point the aliases at dist/**/index.js and set build.target to 'esnext' so
esbuild doesn't downlevel core's modern Babel output. The report is an internal
artifact viewed in current browsers; CSS targets stay modern (lightningcss) to
preserve native light-dark().
Verified: build-report.ts produces a 4-target report.html (Astryx, Astryx+TW,
Baseline, HTML — including the Astryx+TW columns/data), and
deploy-report.ts --dry-run completes end to end. eslint clean.
cixzhang
requested review from
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
josephfarina
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Repairs the nightly vibe-test report build (
build-report.ts, invoked bydeploy-report.tsStep 5), which has been failing since early June — independent ofthe recent target rename.
Why
Two stacked breakages in
internal/vibe-tests/app/vite.config.report.ts:@astryxdesign/coresubpath and rootimports to
dist/**/index.**mjs**, but core's build emits.js(itsbuild:esmstep uses
--out-file-extension '.js'since the switch to the Babel CLI). Vitecould not load the modules →
Could not load .../dist/theme/index.mjs (ENOENT).bundled core to Vite's default
es2020target —Transforming destructuring … is not supported yet(135 errors) — because nobuild.targetis set.The daily Night Watch logs corroborate the timeline: the report deployed fine on
2026-06-20, then began failing ("Report deploy: Failed — build-report.ts error") on
2026-06-22, shortly after core moved to
.jsoutput.Changes
dist/**/index.js(matching what core actually builds).build.target: 'esnext'so esbuild doesn't downlevel core's modern Babel output.The report is an internal artifact viewed in current browsers; CSS targets stay modern
(lightningcss, chrome 123) to preserve native
light-dark().No component source or public types touched.
@astryxdesign/vibe-testsis a private(unpublished) package, so no changeset.
Verification
build-report.tsnow produces a self-contained 4-targetreport.html(~510 KB) — therendered HTML includes the Astryx, Astryx+TW, Baseline, and HTML columns/data.
deploy-report.ts --dry-runcompletes end to end ("Report built but not deployed").eslintclean; repo pre-commit gates (sync, package-boundaries, changesets,demo-media) all pass.