Skip to content

Conversation

@garry00107
Copy link

@garry00107 garry00107 commented Feb 1, 2026

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This PR refactors generateBlogPosts in packages/docusaurus-plugin-content-blog/src/blogUtils.ts to improve the separation of concerns, addressing an existing TODO in the codebase.

Previously, generateBlogPosts was responsible for loading the tags file internally via getTagsFile. This change moves that responsibility to the caller (loadContent in index.ts), making generateBlogPosts a pure function of its inputs with respect to the tags file.

Test Plan

I verified the changes by running the unit tests for the docusaurus-plugin-content-blog package.

Command:

yarn test packages/docusaurus-plugin-content-blog

### Test links

Deploy preview: https://deploy-preview-11707--docusaurus-2.netlify.app/

@meta-cla
Copy link

meta-cla bot commented Feb 1, 2026

Hi @garry00107!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 1, 2026

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit a697f1d
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/697f51ecfb98ed0008149fdd
😎 Deploy Preview https://deploy-preview-11707--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla
Copy link

meta-cla bot commented Feb 1, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed Signed Facebook CLA label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant