[lexical-list] Bug Fix: don't merge adjacent nested lists of a different listType - #8925
Open
LeSingh1 wants to merge 1 commit into
Open
[lexical-list] Bug Fix: don't merge adjacent nested lists of a different listType#8925LeSingh1 wants to merge 1 commit into
LeSingh1 wants to merge 1 commit into
Conversation
…ent listType mergeNextSiblingListIfSameType() only compares listType at the top level. Its recursive helper mergeLists(), and ListItemNode.remove(), merged the sublists at the join point unconditionally, so a nested <ol> next to a nested <ul> lost its type. Compare listType in both places.
LeSingh1
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
August 4, 2026 20:11
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mergeNextSiblingListIfSameType()documents that a<ul>merges with a<ul>but not with an<ol>. That check is only applied to the two top-level lists. The recursive step insidemergeLists(), and the same merge inListItemNode.remove(), join the sublists at the boundary without looking atlistType, so the second sublist loses its type and its items are absorbed into the first.Two reachable paths:
<ul>and a nested<ol>turns the<ol>into bullets.ListNode$transformmerges two adjacent<ul>s whose boundary sublists differ, with the same result.Both sites now compare
listTypebefore merging. When they differ the sublists stay as separate list items; nothing is dropped.Test plan
Before
Two new unit tests fail on main — the
<ol>is replaced by a second<li>inside the<ul>:After
Both pass.
pnpm run test-unitgreen (227 files, 4940 passed).