Skip to content

fix f-str check #4010#4051

Draft
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:4010-f-string
Draft

fix f-str check #4010#4051
asukaminato0721 wants to merge 1 commit into
facebook:mainfrom
asukaminato0721:4010-f-string

Conversation

@asukaminato0721

Copy link
Copy Markdown
Contributor

Summary

Fixes part of #4010

Test Plan

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

Diff from mypy_primer, showing the effect of this PR on open source code:

dulwich (https://github.com/dulwich/dulwich)
+ ERROR dulwich/patch.py:563:40-52: The type `None` doesn't support format specifiers [invalid-argument]

colour (https://github.com/colour-science/colour)
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:101:33-67: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:101:33-67: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:102:10-44: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:102:10-44: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:40-57: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:40-57: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:62-79: The type `floating[_16Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/examples/phenomena/examples_interference_tmm.py:255:62-79: The type `floating[_32Bit]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:344:13-27: The type `ndarray[tuple[Any, ...], dtype[float64 | floating[_16Bit] | floating[_32Bit]]]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `Buffer` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `_NestedSequence[bytes | complex | str]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `_NestedSequence[_SupportsArray[dtype]]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: The type `_SupportsArray[dtype]` doesn't support format specifiers [invalid-argument]
+ ERROR colour/plotting/phenomena.py:672:63-70: Incompatible types in string interpolation (expression has type `bytes`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR colour/plotting/phenomena.py:672:63-70: Incompatible types in string interpolation (expression has type `str`, placeholder has type `complex | float | int`) [bad-argument-type]

materialize (https://github.com/MaterializeInc/materialize)
+ ERROR test/limits/mzcompose.py:74:22-52: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR misc/python/materialize/feature_benchmark/benchmark_result.py:93:22-42: The type `T` doesn't support format specifiers [invalid-argument]
+ ERROR misc/python/materialize/feature_benchmark/benchmark_result.py:107:22-43: The type `T` doesn't support format specifiers [invalid-argument]

freqtrade (https://github.com/freqtrade/freqtrade)
+ ERROR freqtrade/persistence/trade_model.py:879:33-61: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR freqtrade/strategy/interface.py:1656:47-76: The type `None` doesn't support format specifiers [invalid-argument]

pwndbg (https://github.com/pwndbg/pwndbg)
+ ERROR pwndbg/aglib/godbg.py:393:32-41: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:362:45-56: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:366:55-66: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:369:45-56: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:386:49-58: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:433:49-58: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:479:33-44: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:490:47-58: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:503:33-44: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/aglib/onegadget.py:540:43-54: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ktask.py:176:30-40: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:586:33-54: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:586:74-90: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:603:25-46: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:603:66-82: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR pwndbg/commands/ptmalloc2.py:1374:24-35: The type `None` doesn't support format specifiers [invalid-argument]

comtypes (https://github.com/enthought/comtypes)
+ ERROR comtypes/client/lazybind.py:153:47-65: The type `object` doesn't support format specifiers [invalid-argument]

apprise (https://github.com/caronc/apprise)
+ ERROR apprise/plugins/aprs.py:667:33-49: Incompatible types in string interpolation (expression has type `NotifyFormat`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR apprise/plugins/aprs.py:667:33-49: Incompatible types in string interpolation (expression has type `OverflowMode`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR apprise/plugins/aprs.py:667:33-49: Incompatible types in string interpolation (expression has type `str`, placeholder has type `complex | float | int`) [bad-argument-type]
+ ERROR apprise/plugins/aprs.py:667:33-49: The type `None` doesn't support format specifiers [invalid-argument]
- ERROR apprise/plugins/vapid/__init__.py:356:20-43: Object of class `dict` has no attribute `load` [missing-attribute]
- ERROR apprise/plugins/vapid/__init__.py:391:16-22: `not in` is not supported between `object` and `WebPushSubscriptionManager` [unsupported-operation]
- ERROR apprise/plugins/vapid/__init__.py:405:28-65: Argument `EllipticCurvePublicKey | Unknown | None` is not assignable to parameter `public_key` with type `EllipticCurvePublicKey` in function `apprise.utils.pem.ApprisePEMController.encrypt_webpush` [bad-argument-type]
- ERROR apprise/plugins/vapid/__init__.py:405:47-53: Cannot index into `WebPushSubscriptionManager` [bad-index]
- ERROR apprise/plugins/vapid/__init__.py:406:29-67: Argument `bytes | Unknown | None` is not assignable to parameter `auth_secret` with type `bytes` in function `apprise.utils.pem.ApprisePEMController.encrypt_webpush` [bad-argument-type]
- ERROR apprise/plugins/vapid/__init__.py:406:48-54: Cannot index into `WebPushSubscriptionManager` [bad-index]
- ERROR apprise/plugins/vapid/__init__.py:609:42-70: Argument `bytes | None` is not assignable to parameter `data` with type `bytes` in function `apprise.utils.base64.base64_urlencode` [bad-argument-type]

ibis (https://github.com/ibis-project/ibis)
+ ERROR ibis/backends/impala/__init__.py:704:73-88: The type `DataFrame` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/backends/impala/__init__.py:704:73-88: The type `Series` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/expr/operations/generic.py:176:24-40: The type `None` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `bytes`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `complex`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `float`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/operations/udf.py:42:21-35: Incompatible types in string interpolation (expression has type `str`, placeholder has type `int`) [bad-argument-type]
+ ERROR ibis/expr/types/relations.py:3492:20-33: The type `NumericValue` doesn't support format specifiers [invalid-argument]
+ ERROR ibis/expr/types/relations.py:3503:24-37: The type `NumericValue` doesn't support format specifiers [invalid-argument]

aiohttp (https://github.com/aio-libs/aiohttp)
+ ERROR aiohttp/connector.py:1394:36-52: The type `None` doesn't support format specifiers [invalid-argument]

async-utils (https://github.com/mikeshardmind/async-utils)
+ ERROR src/async_utils/lockout.py:83:34-53: The type `list[float]` doesn't support format specifiers [invalid-argument]
+ ERROR src/async_utils/lockout.py:152:34-53: The type `set[Future[None]]` doesn't support format specifiers [invalid-argument]

ignite (https://github.com/pytorch/ignite)
+ ERROR ignite/handlers/checkpoint.py:476:91-105: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR ignite/utils.py:137:30-40: The type `Number` doesn't support format specifiers [invalid-argument]
+ ERROR ignite/utils.py:168:19-29: The type `Number` doesn't support format specifiers [invalid-argument]

pywin32 (https://github.com/mhammond/pywin32)
+ ERROR win32/Demos/getfilever.py:31:40-50: Incompatible types in string interpolation (expression has type `str`, placeholder has type `int`) [bad-argument-type]
+ ERROR win32/Demos/getfilever.py:31:50-64: Incompatible types in string interpolation (expression has type `str`, placeholder has type `int`) [bad-argument-type]

websockets (https://github.com/aaugustin/websockets)
+ ERROR src/websockets/sync/messages.py:89:51-64: The type `None` doesn't support format specifiers [invalid-argument]

pandas (https://github.com/pandas-dev/pandas)
+ ERROR pandas/io/formats/style_render.py:1927:18-23: The type `integer` doesn't support format specifiers [invalid-argument]

meson (https://github.com/mesonbuild/meson)
+ ERROR mesonbuild/mconf.py:358:36-42: The type `list[str]` doesn't support format specifiers [invalid-argument]

@asukaminato0721 asukaminato0721 marked this pull request as draft July 5, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant