Improve bound method callable return diagnostic#4081
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the diagnostic when a callable class attribute is treated as a bound method after instance access. For the
ClassVar[Callable[[], int]]property-return case from #3810, Pyrefly still reports the invalid return, but now the detail explains that_factoryis being bound as a method even though its callable signature has noselfparameter.Fixes #3810
Test Plan
cargo test -p pyrefly test_classvar_callable_return_bound_method_error -- --nocapturecargo test -p pyrefly test_callable_boundmethod_subset -- --nocapturecargo test -p pyrefly test::attributes:: -- --nocapturecargo test -p pyrefly test::callable::cargo fmt --all -- --checkcargo test -p pyreflywas attempted; the full package run hittest::shape_dsl::*per-test timeouts after6202 passed; 19 failed. A representative shape DSL test,test::shape_dsl::test_shape_dsl_arg_count_too_few, passes when run directly.