Update closure compiler #35303
Open
Update closure compiler #35303
+127
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Dec 5, 2025
| rewrite_polyfills: false, | ||
| inject_libraries: false, | ||
| allow_dynamic_import: true, | ||
| dynamic_import_alias: 'import', |
Collaborator
Author
There was a problem hiding this comment.
This option is now required for dynamic import support. We just alias it back to import.
rickhanlonii
approved these changes
Dec 5, 2025
Collaborator
Author
|
Oh no. The new one is not compatible with old version and vice versa. |
poteto
reviewed
Dec 5, 2025
Member
poteto
left a comment
poteto
left a comment
There was a problem hiding this comment.
Nice! I think this means we can remove our custom Java install step too: https://github.com/facebook/react/blob/main/.github/workflows/runtime_build_and_test.yml#L332-L335
Only reason we had it was to support that old version of Closure Compiler.
Member
|
I think you might need to add this to runtime_build_and_test.yml, right at the top: env:
JAVA_HOME: ${{ env.JAVA_HOME_21_X64 }} |
sebmarkbage
force-pushed
the
upgradeclosure
branch
from
b8e7acd to
affe65d
Compare
poteto
reviewed
Dec 5, 2025
sebmarkbage
force-pushed
the
upgradeclosure
branch
from
9553f20 to
ec05cc1
Compare
sebmarkbage
force-pushed
the
upgradeclosure
branch
from
65a87f8 to
6e7b6fa
Compare
sebmarkbage
force-pushed
the
upgradeclosure
branch
from
6e7b6fa to
96ba6c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old one is not supported on newer OpenJDK.