Skip to content

fix(mcp): Gracefully shutdown background indexing task on exit #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sashalevin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mcp): Gracefully shutdown background indexing task on exit #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/bin/semcode-mcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5437,7 +5437,7 @@ async fn main() -> Result<()> {
let git_repo_for_indexing = args.git_repo.clone();
let indexing_state_for_bg = server.indexing_state.clone();
let notification_tx_for_bg = server.notification_tx.clone();
let _indexing_handle = tokio::spawn(async move {
let indexing_handle = tokio::spawn(async move {
// Ensure tables exist before indexing
if let Err(e) = db_for_indexing.create_tables().await {
eprintln!("[Background] Error creating/verifying tables: {}", e);
Expand All @@ -5458,6 +5458,10 @@ async fn main() -> Result<()> {
// Run MCP server on stdio
run_stdio_server(server).await?;

// Gracefully shutdown the background indexing task
indexing_handle.abort();
let _ = indexing_handle.await;

Ok(())
}

Expand Down