Conversation
stefanwebb
left a comment
There was a problem hiding this comment.
This is really fantastic - I think it's almost there! Let's have a chat offline about coupling transforms, I think there may be a few ways to interpret them from the literature
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 98.25% 98.29% +0.04%
==========================================
Files 6 6
Lines 229 235 +6
==========================================
+ Hits 225 231 +6
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
# Conflicts: # flowtorch/bijectors/base.py # flowtorch/bijectors/compose.py # flowtorch/bijectors/ops/spline.py # tests/test_bijector.py
Summary: ### Motivation As pointed out in #85, it may be preferable to use `softplus` rather than `exp` to calculate the scale parameter of the affine map in `bij.ops.Affine`. ### Changes proposed Another PR #92 by vmoens implements `softplus`, `sigmoid`, and `exp` options for the scale parameter - I have factored that out and simplified some of the design in order to make #92 easier for review. `softplus` is now the default option for `Affine` Pull Request resolved: #109 Test Plan: `pytest tests/` Reviewed By: vmoens Differential Revision: D36169529 Pulled By: stefanwebb fbshipit-source-id: 625387e10399291a5a404c28f4ada743d0945649
|
Hi @vmoens! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Adds Coupling layers.
### Test plan