refactor: Add chunkSize to ChunkLocation and rename ChunkIndexWriter::newStripe#667
Open
xiaoxmeng wants to merge 1 commit into
Open
refactor: Add chunkSize to ChunkLocation and rename ChunkIndexWriter::newStripe#667xiaoxmeng wants to merge 1 commit into
xiaoxmeng wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@xiaoxmeng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101830061. |
xiaoxmeng
force-pushed
the
export-D101830061
branch
3 times, most recently
from
7068006 to
c76d2f4
Compare
…:newStripe Summary: CONTEXT: ChunkLocation only stored stream offset and row offset but not the chunk byte size. Callers needed to compute chunk size by looking at the next chunk offset or stream size, duplicating logic in multiple places. WHAT: - Add chunkSize field to ChunkLocation for self-contained chunk metadata - StreamIndex::create and createStreamIndex now take streamSize parameter to compute last chunk size - Rename ChunkIndexWriter::newStripe → finishStripe for clarity - Rename ChunkLocation::streamOffset → chunkOffset for consistency Reviewed By: tanjialiang Differential Revision: D101830061
xiaoxmeng
force-pushed
the
export-D101830061
branch
from
c76d2f4 to
0b53515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
CONTEXT: ChunkLocation only stored stream offset and row offset but not the chunk byte size. Callers needed to compute chunk size by looking at the next chunk offset or stream size, duplicating logic in multiple places.
WHAT:
Reviewed By: tanjialiang
Differential Revision: D101830061