feat: Populate footerBufferOverread for Nimble speculative IO#708
Closed
kewang1024 wants to merge 1 commit into
Closed
feat: Populate footerBufferOverread for Nimble speculative IO#708kewang1024 wants to merge 1 commit into
kewang1024 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@kewang1024 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104326159. |
meta-codesync
Bot
changed the title
kewang1024
pushed a commit
to kewang1024/nimble
that referenced
this pull request
May 8, 2026
…okincubator#708) Summary: CONTEXT: Nimble speculative IO reads a configurable tail chunk (default 8MB) to load the file footer in one read. DWRF already reports `footerBufferOverread` in runtime stats to measure the wasted bytes from speculative reads, but Nimble does not. WHAT: Compute and expose `footerBufferOverread` in `TabletReader::loadAndInitFooter()` as `speculativeIoSize - (footerSize + postscriptSize)`, and populate `stats.footerBufferOverread` in `SelectiveNimbleRowReader::updateRuntimeStats()`. This reuses the existing DWRF stat with the same semantics. Differential Revision: D104326159
kewang1024
force-pushed
the
export-D104326159
branch
from
0fd4ca4 to
4dab0ed
Compare
meta-codesync
Bot
changed the title
kewang1024
force-pushed
the
export-D104326159
branch
from
4dab0ed to
2db0379
Compare
Summary: Compute and expose `footerBufferOverread` via `TabletReader::Stats` for Nimble speculative IO. In speculative mode, we read a configurable tail chunk to load the footer in one read. This stat captures the wasted bytes (`speculativeIoSize - requiredSize`), matching the existing DWRF `RuntimeStatistics::footerBufferOverread` semantics. Reviewed By: xiaoxmeng Differential Revision: D104326159
kewang1024
force-pushed
the
export-D104326159
branch
from
2db0379 to
7923a04
Compare
|
This pull request has been merged in 34aa47c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Compute and expose
footerBufferOverreadviaTabletReader::Statsfor Nimble speculative IO. In speculative mode, we read a configurable tail chunk to load the footer in one read. This stat captures the wasted bytes (speculativeIoSize - requiredSize), matching the existing DWRFRuntimeStatistics::footerBufferOverreadsemantics.Reviewed By: xiaoxmeng
Differential Revision: D104326159