feat: Log selected flat map feature names in keySelectionCallback#752
Open
apurva-meta wants to merge 1 commit into
Open
feat: Log selected flat map feature names in keySelectionCallback#752apurva-meta wants to merge 1 commit into
apurva-meta wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Summary:
Adds a new optional `flatMapFeatureProjectionCallback` on Nimble's `FieldReaderParams` that, when set, is invoked once per flat map column during `createFieldReaderFactory()` with the column name and the names of the features that were actually projected (in the caller-specified order).
This gives loggers (e.g. Scuba/ODS pipelines) the information needed to inform write-time flat map feature reordering configurations (`VeloxWriterOptions::featureReordering` / `FeatureReorderingLayoutPlanner`), addressing the gap noted in T237389198 where the existing `keySelectionCallback` only reports aggregate `{totalKeys, selectedKeys}` counts.
The existing `keySelectionCallback` path is unchanged, and the new callback defaults to nullptr so all existing callers are unaffected. No Velox / DWRF / DWIO API headers are touched, so this is safe for the OSS Nimble build (which pins an older Velox snapshot).
Reviewed By: srsuryadev
Differential Revision: D105609449
apurva-meta
force-pushed
the
export-D105609449
branch
from
4921b50 to
0617d7e
Compare
|
@apurva-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105609449. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a new optional
flatMapFeatureProjectionCallbackon Nimble'sFieldReaderParamsthat, when set, is invoked once per flat map column duringcreateFieldReaderFactory()with the column name and the names of the features that were actually projected (in the caller-specified order).This gives loggers (e.g. Scuba/ODS pipelines) the information needed to inform write-time flat map feature reordering configurations (
VeloxWriterOptions::featureReordering/FeatureReorderingLayoutPlanner), addressing the gap noted in T237389198 where the existingkeySelectionCallbackonly reports aggregate{totalKeys, selectedKeys}counts.The existing
keySelectionCallbackpath is unchanged, and the new callback defaults to nullptr so all existing callers are unaffected. No Velox / DWRF / DWIO API headers are touched, so this is safe for the OSS Nimble build (which pins an older Velox snapshot).Reviewed By: srsuryadev
Differential Revision: D105609449