refactor: Move keyAtRow from IndexLookup to ClusterIndex only (#760)#760
Open
duxiao1212 wants to merge 1 commit into
Open
refactor: Move keyAtRow from IndexLookup to ClusterIndex only (#760)#760duxiao1212 wants to merge 1 commit into
duxiao1212 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@duxiao1212 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105885845. |
…okincubator#760) Summary: keyAtRow is fundamentally tied to ClusterIndex's design: it relies on the dedicated key stream written when data is physically sorted by key. HashIndex and SortedIndex inherited a method they are meaningless to support. Differential Revision: D105885845
meta-codesync
Bot
changed the title
duxiao1212
force-pushed
the
export-D105885845
branch
from
198d7c2 to
d843f0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
keyAtRow is fundamentally tied to ClusterIndex's design: it relies on the dedicated key stream written when data is physically sorted by key.
HashIndex and SortedIndex inherited a method they are meaningless to support.
Differential Revision: D105885845