perf: Call reserve() upfront to avoid unnecessary reallocation (#765)#765
Closed
MatzeB wants to merge 1 commit into
Closed
perf: Call reserve() upfront to avoid unnecessary reallocation (#765)#765MatzeB wants to merge 1 commit into
MatzeB wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@MatzeB has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100823409. |
…ookincubator#765) Summary: This change was generated by pointing an AI agent at hot functions showing up in our internal profiles. It was reviewed by a human (outside the velox team): Added `decoders_.reserve(streams.size())` before the loop in `VeloxReader::loadNextStripe()` that populates the `folly::F14FastMap<offset_size, std::unique_ptr<Decoder>> decoders_` container. The map is cleared right before this loop, so reserving `streams.size()` buckets upfront avoids expensive rehashing during the insertion loop. No functionality changes were made. Reviewed By: yuxuanchen1997 Differential Revision: D100823409
meta-codesync
Bot
changed the title
|
This pull request has been merged in b52daa9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change was generated by pointing an AI agent at hot functions showing up in our internal profiles. It was reviewed by a human (outside the velox team):
Added
decoders_.reserve(streams.size())before the loop inVeloxReader::loadNextStripe()that populates thefolly::F14FastMap<offset_size, std::unique_ptr<Decoder>> decoders_container. The map is cleared right before this loop, so reservingstreams.size()buckets upfront avoids expensive rehashing during the insertion loop. No functionality changes were made.Reviewed By: yuxuanchen1997
Differential Revision: D100823409