This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Fix model output shape retrieval during flops calculation#556
Open
miteshksingh wants to merge 1 commit intofacebookresearch:mainfrom
Open
Fix model output shape retrieval during flops calculation#556miteshksingh wants to merge 1 commit intofacebookresearch:mainfrom
miteshksingh wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Use get_input_shape function (added recently in D21702925 (facebookresearch@f0528a1)) to get the shape of output. Updated the function name to get_shape to include both input and output. Differential Revision: D22327937 fbshipit-source-id: 321deffde974f267edcf9e1b7ca773d4df7444b7
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22327937 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem
Output of a model can be Dict as well. L350 of generic/profiler.py assumes the output to be a tensor, thus failing whenever model output is a Dict.
Solution
Use
get_input_shapefunction (added recently in D21702925 (f0528a1)) to get the shape of output. Updated the function name toget_shapeto include both input and output.Differential Revision: D22327937