This repository was archived by the owner on Jul 1, 2024. It is now read-only.
add extra work during phrase advance in classification task#630
Open
stephenyan1231 wants to merge 4 commits intofacebookresearch:mainfrom
Open
add extra work during phrase advance in classification task#630stephenyan1231 wants to merge 4 commits intofacebookresearch:mainfrom
stephenyan1231 wants to merge 4 commits intofacebookresearch:mainfrom
Conversation
Differential Revision: D21949491 fbshipit-source-id: fc85f28421169ae7617e781592773802e4dd5c62
Differential Revision: D23191690 fbshipit-source-id: e3ff067ed472f1b9e36b598a921a2d4930cddd5c
Differential Revision: D23261222 fbshipit-source-id: 46643b527cceb66bcc4f88af905615b61cafe036
Summary: Allow to do extra work during phrase advance in the child class of classification task. This will avoid duplicate code. For example, in `classification_task_with_dict_output.py` of D24528158, the extra work is to refresh the weighted-sampled dataset. Differential Revision: D24586321 fbshipit-source-id: 4e420aad3fe8df4596688073938f5d66a1a6174e
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D24586321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Allow to do extra work during phrase advance in the child class of classification task. This will avoid duplicate code.
For example, in
classification_task_with_dict_output.pyof D24528158, the extra work is to refresh the weighted-sampled dataset.Differential Revision: D24586321