Closed
Conversation
Summary: This diff adds support for configurable TPR (True Positive Rate) targets in MIA. **Key Changes:** - Added `tpr_target` parameter: Allows users to specify a custom TPR threshold (default behavior remains 1% if not specified) - Added `tpr_threshold_width` parameter: Controls the granularity of TPR thresholds (default: 0.25%) - Added input validation for `tpr_threshold_width` (must be positive and evenly divide 99%, e.g., 0.1%, 0.25%, 0.3%, 0.5%, etc.) - Added unit tests for the changes in this diff - `test_get_tpr_index_none_target` to verify legacy behavior (Returns index 0 when `tpr_target=None`) - `test_get_tpr_index_with_target` to verify `get_tpr_index` returns the correct index - `test_tpr_threshold_width_positive_validation` to verify ValueError is raised when `tpr_threshold_width <= 0` - `test_tpr_threshold_width_divisibility_validation` to verify ValueError is raised when `tpr_threshold_width` doesn't evenly divide 0.99 **Backward Compatibility:** - Fully backward compatible - existing configs without `tpr_target` continue to use the original 1% TPR with 100 thresholds Differential Revision: D92439701
meta-cla
bot
added
the
CLA Signed
|
@lucamelis has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92439701. |
|
This pull request has been merged in 235d105. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support for configurable TPR (True Positive Rate) targets in MIA.
Key Changes:
tpr_targetparameter: Allows users to specify a custom TPR threshold (default behavior remains 1% if not specified)tpr_threshold_widthparameter: Controls the granularity of TPR thresholds (default: 0.25%)tpr_threshold_width(must be positive and evenly divide 99%, e.g., 0.1%, 0.25%, 0.3%, 0.5%, etc.)test_get_tpr_index_none_targetto verify legacy behavior (Returns index 0 whentpr_target=None)test_get_tpr_index_with_targetto verifyget_tpr_indexreturns the correct indextest_tpr_threshold_width_positive_validationto verify ValueError is raised whentpr_threshold_width <= 0test_tpr_threshold_width_divisibility_validationto verify ValueError is raised whentpr_threshold_widthdoesn't evenly divide 0.99Backward Compatibility:
tpr_targetcontinue to use the original 1% TPR with 100 thresholdsDifferential Revision: D92439701