This repository was archived by the owner on Dec 18, 2023. It is now read-only.
Support parameters in World#1605
Open
feynmanliang wants to merge 1 commit intofacebookresearch:mainfrom
Open
Conversation
Summary: To support the use of `bm.param`s in the generative model, beanmachine's VI now: * Traces through `World` in addition to `VariationalWorld` so that `param`s used in `World` are added to the optimizer * Utilizes a `VariationalWorld` for both the generative and guide distributions in `gradient_estimators` so that `params` can be used in the generative model This is needed to support PPCA (N2358633) Differential Revision: D38754091 fbshipit-source-id: c110e22f9a4b7c9c86e37b9884d8e931466a0abf
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38754091 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
To support the use of
bm.params in the generative model, beanmachine's VI now:Worldin addition toVariationalWorldso thatparams used inWorldare added to the optimizerVariationalWorldfor both the generative and guide distributions ingradient_estimatorsso thatparamscan be used in the generative modelThis is needed to support PPCA (N2358633)
Differential Revision: D38754091