Fix C++ code generation for typed eigen matrices.#1688
Fix C++ code generation for typed eigen matrices.#1688ericlippert wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Eigen distinguishes between matrices of bools, naturals and doubles; when generating a C++ fragment to construct a BMG graph, we always generated a double matrix, but that's bad; it will not type check when compiled by the C++ compiler since the BMG methods for constructing constant matrices require an input of the appropriate type. Reviewed By: gafter, AishwaryaSivaraman Differential Revision: D39632858 fbshipit-source-id: aef37f30537fc690ed7756822a373f7411559669
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39632858 |
|
Hi @ericlippert! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
2 participants
Summary: Eigen distinguishes between matrices of bools, naturals and doubles; when generating a C++ fragment to construct a BMG graph, we always generated a double matrix, but that's bad; it will not type check when compiled by the C++ compiler since the BMG methods for constructing constant matrices require an input of the appropriate type.
Reviewed By: gafter, AishwaryaSivaraman
Differential Revision: D39632858