Continue implementing broadcasting semantics in compiler#1743
Continue implementing broadcasting semantics in compiler#1743ericlippert wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: We're continuing to add broadcasting semantics by small steps. In this diff: * I've fixed a bug in how requirements on the matrix add incoming edges are represented. The correct representation is that the input types must be identical to the output types. In the test case, the output type is a 2x2 real matrix, so the inputs must also be 2x2 real matrices. * I've fixed a bug in the error message when that requirement is not met; previously it said that the requirement was "a real" regardless of what the actual requirement was. The requirement is "a real 2x2 matrix" in this example, so that's what we say in the error message. * The code which handled detecting that there's a problem with the dimensions was hard to read. I refactored it to introduce explanatory variables. Since we do not yet introduce a broadcast node, the correct thing to do here is to give an error, which we now do. In an upcoming diff we'll instead insert a broadcast node. Reviewed By: AishwaryaSivaraman Differential Revision: D40046224 fbshipit-source-id: 30e605dfdb52bed68144ad982a05155547213716
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40046224 |
|
Hi @ericlippert! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
2 participants
Summary:
We're continuing to add broadcasting semantics by small steps. In this diff:
Since we do not yet introduce a broadcast node, the correct thing to do here is to give an error, which we now do. In an upcoming diff we'll instead insert a broadcast node.
Reviewed By: AishwaryaSivaraman
Differential Revision: D40046224