This repository was archived by the owner on Dec 18, 2023. It is now read-only.
Try using src as the source directory#1778
Open
stroxler wants to merge 2 commits intofacebookresearch:mainfrom
Open
Try using src as the source directory#1778stroxler wants to merge 2 commits intofacebookresearch:mainfrom
src as the source directory#1778stroxler wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
Summary: Pull Request resolved: facebookresearch#1751 Added in the .pyre_configuration.external file needed for configurator - Following the steps laid out in: https://www.internalfb.com/intern/staticdocs/pyre/docs/fb/open-source-setup/ Differential Revision: https://internalfb.com/D40400698 fbshipit-source-id: eef64061925528d08a88bf3fd122ea1904017c3f
Summary: This may lead to more code being type checked than desired, but I think we can use excludes to handle this if that is a problem. Differential Revision: D40606047 fbshipit-source-id: 02a37c5b3a792a2202f5e91c8460bb5c2f68b51d
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40606047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This may lead to more code being type checked than desired,
but I think we can use excludes to handle this if that is a problem.
Differential Revision: D40606047