This repository was archived by the owner on Dec 18, 2023. It is now read-only.
[WIP] Pytest: Split & parametrise model/inference (intra-module)#1809
Open
[WIP] Pytest: Split & parametrise model/inference (intra-module)#1809
Conversation
- port: unittest -> pytest - factor out as fixtures: models, samplers, proposers - standardise RV names in models with similar structures - reduce intra-module code redundancy - apply linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As a first step of the Pytest suite refactoring and extension, the model/observation/inference choices in the existing tests are explicitly parametrised as fixtures, and local (intra-module) redundancies are factored out. In a subsequent PR, the module hierarchy of the test suite will be reorganised.
Since the implied change set is of considerable size, at the time of opening this PR the refactoring is only carried out on a representative subset of the test suite, and will be extended over the rest upon initial feedback.
Changes proposed
unittest->pytest)src/beanmachine/ppl/examplestests/ppl/utils/fixtures.pyTest Plan
pytestTypes of changes
Checklist