Open
Conversation
The maxDepth of 256 still triggered a stack overflow because our maximum stack size was 512 and the stack grows by 2 during each recursion. The 50 chosen here is arbitrary.
Member
|
Hi @mhvis
would you try to propose a fix for the growth by 2x? Also, would you try the make the parameter I'm sorry, but I won't accept a PR to simply change that value. |
Contributor
Author
|
Yes sure no problem! Cannot guarantee when I'll get to it though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maxDepth of 256 still triggered a stack overflow because our maximum stack size was 512 and the stack grows by 2 during each recursion.
The 50 chosen here is arbitrary.