-
-
Notifications
You must be signed in to change notification settings - Fork 852
✨ Suppress modules in Rich tracebacks with pretty_exceptions_suppress
#1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harkabeeparolus
wants to merge
16
commits into
fastapi:master
Choose a base branch
from
harkabeeparolus:feature/traceback_suppress
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+211
−4
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
77ee838
Option to suppress modules in Rich tracebacks
harkabeeparolus fffa6ee
Ruff format
harkabeeparolus dc55834
Merge branch 'master' into feature/traceback_suppress
harkabeeparolus 41ce825
🎨 Auto format
pre-commit-ci-lite[bot] 8e2cd62
Fix spelling and grammar in docs
harkabeeparolus e2d539d
Update to new docs filenames
harkabeeparolus 20b19c5
Merge branch 'feature/traceback_suppress' of https://github.com/harka…
harkabeeparolus b4fd484
Merge branch 'master' into feature/traceback_suppress
svlandeg 4ccfe2b
Merge branch 'master' into feature/traceback_suppress
harkabeeparolus a3260ec
Add test for pretty_exceptions_suppress tutorial
harkabeeparolus e7e5ef7
Merge branch 'master' into feature/traceback_suppress
harkabeeparolus 667b16d
Merge remote-tracking branch 'upstream/master' into feature/traceback…
harkabeeparolus 4f0f195
Rename tutorial to _py310
harkabeeparolus a2f39df
Update docs include for renamed tutorial src file
harkabeeparolus 8f4d73d
Replace gitlab example with urllib.request
harkabeeparolus a6ae225
Merge branch 'master' into feature/traceback_suppress
harkabeeparolus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import urllib.request | ||
|
|
||
| import typer | ||
|
|
||
| app = typer.Typer(pretty_exceptions_suppress=[urllib.request]) | ||
|
|
||
|
|
||
| @app.command() | ||
| def main(): | ||
| urllib.request.urlopen("unknown://example.com") | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| app() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import os | ||
| import subprocess | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| from typer.testing import CliRunner | ||
|
|
||
| from docs_src.exceptions import tutorial005_py310 as mod | ||
|
|
||
| runner = CliRunner() | ||
|
|
||
|
|
||
| def test_pretty_exceptions_suppress(): | ||
| file_path = Path(mod.__file__) | ||
| result = subprocess.run( | ||
| [sys.executable, "-m", "coverage", "run", str(file_path)], | ||
| capture_output=True, | ||
| encoding="utf-8", | ||
| env={ | ||
| **os.environ, | ||
| "TYPER_STANDARD_TRACEBACK": "", | ||
| "_TYPER_STANDARD_TRACEBACK": "", | ||
| }, | ||
| ) | ||
| assert result.returncode != 0 | ||
| assert "URLError" in result.stderr | ||
| # The user's own code should still appear with full context | ||
| assert "urllib.request.urlopen" in result.stderr | ||
| # Suppressed output is ~28 lines (only user's frame + collapsed library frames). | ||
| # Without suppression it would be ~59 lines (all frames expanded with source context). | ||
| # Threshold of 35 is generous enough for formatting changes but catches unsuppressed output. | ||
| assert len(result.stderr.splitlines()) < 35 | ||
|
|
||
|
|
||
| def test_script(): | ||
| result = subprocess.run( | ||
| [sys.executable, "-m", "coverage", "run", mod.__file__, "--help"], | ||
| capture_output=True, | ||
| encoding="utf-8", | ||
| ) | ||
| assert "Usage" in result.stdout |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.