feat: Allow tasks with zero height/width in COCO and Pascal VOC converters #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rters Remove early return check for zero dimensions in to_coco and to_pascalvoc functions. These formats don't use division by dimensions (unlike YOLO), so zero values are safe and should be included in the output. Add tests to verify zero dimension handling for both converters. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
h-iwata
approved these changes
Dec 22, 2025
h-iwata
left a comment
h-iwata
left a comment
There was a problem hiding this comment.
fastlabel_apiに対する単体テストの追加は今回初めてですかね？単体testは無いより合ったほうが格段にいいですね！
セットアップ部分は共通化した方が見やすいと思いますが、もう少し複雑な分岐のあるメソッドのテストを書くようになった時に色々と考えていくのがいいと思います。
|
@rikunosuke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to_cocoとto_pascalvoc関数でheight=0またはwidth=0のタスクがスキップされる問題を修正Changes
converters.py:to_cocoとto_pascalvocから早期リターンチェックを削除tests/test_converters.py: 6つのテストケースを追加Test plan
pytest tests/test_converters.pyで全テスト通過を確認🤖 Generated with Claude Code