CDTOOL-1264: Introduce 'service version ...' commands and 'service-version ...' aliases. #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the 'service purge' command as a replacement for the 'purge' command. The 'purge' command is still available as an alias, but will issue a deprecation warning when it is used.
…es for 'fastly service version' commands.
CHANGELOG.md
Outdated
| - feat(commands/ngwaf/rules): add support for CRUD operations for NGWAF rules ([#1605](https://github.com/fastly/cli/pull/1605)) | ||
| - feat(compute/deploy): added the `--no-default-domain` flag to allow for the skipping of automatic domain creation when deploying a Compute service([#1610](https://github.com/fastly/cli/pull/1610)) | ||
| - feat(commands/service/purge): Add 'service purge' command as replacement for 'purge', with an unlisted and deprecated alias of 'purge'. ([#1612](https://github.com/fastly/cli/pull/1612)) | ||
| - feat(commands/service/version): Add 'service version ...' commands as replacements for 'service-version ...', with unlisted and deprecated aliases of 'service-version ...'. ([#XXX](https://github.com/fastly/cli/pull/XXX)) |
Contributor
There was a problem hiding this comment.
is there another PR for this or is XXXX supposed to be this one
Contributor
Author
There was a problem hiding this comment.
LOL... forgot to update it with the PR number. Will do that now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: This includes the changes from #1612, and will be rebased once that PR is merged.
Change summary
This PR adds the 'service version ...' commands as a replacement for the 'service-version ...' commands. The 'service-version ...' commands are still available as aliases, but will issue a deprecation warning when used (except when JSON output is requested).
This involved a number of changes:
structembedding to avoid duplicating any of the code from the `pkg/commands/service/version' package. The alias commands are 'unlisted' and issue a deprecation warning when used.All Submissions:
New Feature Submissions:
User Impact
New deprecation warning for the
service-version ...commands.