Skip to content

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Jan 13, 2026

Change summary

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
make test TEST_ARGS="-run TestDomainCreate ./pkg/commands/domain"
ok      github.com/fastly/cli/pkg/commands/domain       1.063s
make test TEST_ARGS="-run TestDomainList ./pkg/commands/doma
in"
ok      github.com/fastly/cli/pkg/commands/domain       1.044s
make test TEST_ARGS="-run TestDomainDescribe ./pkg/commands/
domain"
ok      github.com/fastly/cli/pkg/commands/domain       1.045s
make test TEST_ARGS="-run TestDomainUpdate ./pkg/commands/do
main"
ok      github.com/fastly/cli/pkg/commands/domain       1.052s
make test TEST_ARGS="-run TestDomainDelete ./pkg/commands/do
main"
ok      github.com/fastly/cli/pkg/commands/domain       1.044s

---
make test TEST_ARGS="-run TestDomainDelete ./pkg/commands/service/domain"
ok      github.com/fastly/cli/pkg/commands/service/domain       1.047s
make test TEST_ARGS="-run TestDomainValidate ./pkg/commands/
service/domain"
ok      github.com/fastly/cli/pkg/commands/service/domain       1.072s
make test TEST_ARGS="-run TestDomainUpdate ./pkg/commands/se
rvice/domain"
ok      github.com/fastly/cli/pkg/commands/service/domain       1.051s
make test TEST_ARGS="-run TestDomainDescribe ./pkg/commands/
service/domain"
ok      github.com/fastly/cli/pkg/commands/service/domain       1.059s
make test TEST_ARGS="-run TestDomainList ./pkg/commands/serv
ice/domain"
ok      github.com/fastly/cli/pkg/commands/service/domain       1.062s
 make test TEST_ARGS="-run TestDomainCreate ./pkg/commands/se
rvice/domain"
ok      github.com/fastly/cli/pkg/commands/service/domain       1.049s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

Service version oriented domain commands have been moved under the service domain command. Versionless domainv1 commands have been moved to the domain command.

Are there any considerations that need to be addressed for release?

End users that are using the CLI in any workflows for domains will need to update accordingly for these command changes.

@rcaril rcaril changed the title [CDTOOL-1256] Move domainv1 commands to domain and move prior domain command to service/domain [Breaking][CDTOOL-1256] Move domainv1 commands to domain and move prior domain command to service/domain Jan 13, 2026
@rcaril rcaril marked this pull request as ready for review January 13, 2026 18:40
@rcaril rcaril requested a review from a team as a code owner January 13, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants