Fix sub-threshold sessions leaving transcript and summary artifacts#4509
Open
ComputelessComputer wants to merge 2 commits intomainfrom
Open
Fix sub-threshold sessions leaving transcript and summary artifacts#4509ComputelessComputer wants to merge 2 commits intomainfrom
ComputelessComputer wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ComputelessComputer
force-pushed
the
fix-hide-empty-transcript-and-summary-tabs
branch
from
ab584a3 to
5002f50
Compare
ComputelessComputer
requested review from
goranmoomin
and removed request for
yujonglee
goranmoomin
force-pushed
the
fix-hide-empty-transcript-and-summary-tabs
branch
from
42584eb to
cfaf3f4
Compare
Add comprehensive fallback handling when selected tabs become unavailable. Enhance transcript word counting with error handling and improve type safety in eligibility checks. - Add fallback to raw tab when transcript is no longer available - Fallback to first enhanced note when selected note is missing - Improve error handling in transcript word parsing with try-catch - Replace hardcoded threshold with shared constant - Add comprehensive test coverage for tab computation scenarios - Strengthen type definitions for transcript word store interface
goranmoomin
force-pushed
the
fix-hide-empty-transcript-and-summary-tabs
branch
from
cfaf3f4 to
a94d4e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reasoning: when we really have nothing recorded nor jotted down, it should remain in a clean state. but currently we always get three tabs: summary, memos, and transcript.