feat/prevent-trial-expired-onboarding #3410
Open
+116
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hyprnote canceled.
|
❌ Deploy Preview for howto-fix-macos-audio-selection failed.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
ComputelessComputer
force-pushed
the
feat/prevent-trial-expired-onboarding
branch
2 times, most recently
from
606bfb8 to
597d2b7
Compare
Centralize the "is onboarding" check by adding useOnboardingState() and replace inline useLocation pathname checks across several hooks. This removes repeated logic, simplifies imports, and makes onboarding detection reusable. Changes: - Add apps/desktop/src/hooks/useOnboardingState.ts to expose a memoized boolean for onboarding path. - Update useProSubscriptionModalTrigger, useTrialExpiredModalTrigger, and useTrialStartOnFirstLaunch to use the new hook instead of directly using useLocation. - Remove unused useLocation imports and tidy up related effects (rename startTrial mutation usage and its dependency).
ComputelessComputer
force-pushed
the
feat/prevent-trial-expired-onboarding
branch
from
597d2b7 to
4c080f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description